fix(sort): always install SIGINT handler to ensure temp dir cleanup#11889
Merged
Conversation
The `should_install_signal_handler()` check added in 87c332c skipped handler installation on systems with many open FDs, meaning Ctrl+C left `/tmp/uutils_sortXXXX` directories behind with no cleanup at all. Now the handler is always attempted; `ctrlc::set_handler` failing naturally is sufficient. Failure is treated as non-fatal. Closes: uutils#11728
mattsu2020
changed the title
|
GNU testsuite comparison: |
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
should_install_signal_handler()check added in87c332c72skipped SIGINT handler installation on systems with many open FDs, meaning Ctrl+C left/tmp/uutils_sortXXXXdirectories behind with no cleanup at all.Now the handler is always attempted;
ctrlc::set_handlerfailing naturally is sufficient. Failure is treated as non-fatal.Root Cause
remove_tmp_dir→exit(2)TempDir::DropOn Ubuntu 26.04 and systems with many open FDs, the SIGINT handler was never installed, so every interrupted
sortleaked its temp directory.Test
cargo check -p uu_sortpassescargo test -p uu_sort— all 28 tests passCloses: #11728
We will also address the PR below and close the issue.
#11888